-
Notifications
You must be signed in to change notification settings - Fork 25
DOCSP-50338: Reorganize Data Formats pages #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-50338: Reorganize Data Formats pages #642
Conversation
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple questions, so I will take another look!
Serialization </serialization> | ||
Document Formats </document-formats> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: in this reorg, is the goal to move all the content from "Data Formats" into either "Serialization" or "Document Formats"? In that case should you delete the "Data Formats" page? right now it's just a landing page with no L2 pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also the empty "Custom Types" page is linked on "Data Formats"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix!
Serialization | ||
------------- | ||
|
||
Learn how to serialize and deserialize data in the :ref:`csharp-serialization` section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I: I can't comment on the page directly, but serialization/custom-types is just a blank page. did you mean to delete it or is there missing content?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's also not accessible in the Serialization drawer, only if you go to the link directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will delete that page!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + one comment
@@ -96,6 +99,11 @@ rather than keyword matches in the | |||
`Atlas Vector Search <https://www.mongodb.com/docs/atlas/atlas-search/tutorial/>`__ | |||
documentation. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I: you can remove the Data Formats section from lines 71-75
Pull Request Info
For context – we got some feedback from Robert on the C# team that the Data Formats pages didn't have a clear unifying principle, so I broke them out into separate topics.
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-50338
Staging Links
Self-Review Checklist